Skip to content

Bug fixes, GEOS specific changes and documentation updates#11

Merged
FlorianDeconinck merged 42 commits into
geos/mainfrom
debug/pchakrab/aquaplanet/root-358b60d
Apr 20, 2023
Merged

Bug fixes, GEOS specific changes and documentation updates#11
FlorianDeconinck merged 42 commits into
geos/mainfrom
debug/pchakrab/aquaplanet/root-358b60d

Conversation

@pchakraborty

@pchakraborty pchakraborty commented Mar 2, 2023 •
edited by FlorianDeconinck
Loading

Copy link
Copy Markdown
Collaborator

Purpose

A fix for pkz, diss_est and some GEOS specific changes.

Code changes:

  • Accumulate diss_est
  • Initialize geos_dycore_wrapper with a timestep (bdt) that is provided by GEOS
  • Add qcld to the list of tracers being advected
  • GEOS specific changes to thresholds in saturation adjustment
  • GEOS specific values of constants (these are minor changes, but cause significant differences)
  • Fixed a bug in the temperature_adjust stencil that was computing pkz twice.
  • Fix DaCe version to checked 0.14.0
  • Extend DaCe tooling for automatic kenrnel analysis by passing pre-defined hardware bandwith
  • Fix DaCe debug pass
  • GEOS wrapper change to allow for Device <> Device transfer

pchakraborty and others added 13 commits January 26, 2023 20:47
@pchakraborty
Initialize GeosDycoreWrapper with bdt (timestep)
6d78659
@pchakraborty
Use GEOS version of constants
0a3e857
@pchakraborty
1. Add qcld to the list of tracers beings advected
0a8d705 
2. Made GEOS specific changes to thresholds in saturation adjustment
@pchakraborty
Accumulate diss_est
3b73d71
@FlorianDeconinck
Fix & extend debug pass. Add progress pass. Add PACE_DACE_DEBUG to tr…
87e2e4a 
…igger syncdebug mode. Make sure optional SM is used
@FlorianDeconinck
Merge branch 'feature/f32_precision' into feature/dace_debug
392745d
@FlorianDeconinck
Merge branch 'feature/f32_precision' into feature/dace_debug
8a25702
@FlorianDeconinck
Fix intermediate field required at 64 bit precision
027ee8f
@FlorianDeconinck
Allow GEOS_WRAPPER to process device data
a68d160
@FlorianDeconinck
Add clear to collector for 3rd party use. GEOS pass down timings to c…
33ba53f 
…aller
@FlorianDeconinck
Merge branch 'geos/main' into feature/dace_debug
57313e1
@FlorianDeconinck
Merge branch 'geos/main' into opt_geos_wrapper_bridge
8968698
@FlorianDeconinck
Update orchestration primer
d36ffec
@pchakraborty pchakraborty changed the title Debug/pchakrab/aquaplanet/root 358b60d fix for diss_est and some GEOS specific changes Mar 2, 2023
@pchakraborty pchakraborty self-assigned this Mar 2, 2023
@FlorianDeconinck
Make kernel analysis run a copy stencil to compute local bandwith
2327cbe 
Parametrize tool with backend, output format
@FlorianDeconinck
Move constant on a env var
cb4ec5f 
Add saturation adjustement threshold to const
@FlorianDeconinck
lint
7348922
@FlorianDeconinck
lint
e234d16
@FlorianDeconinck
More linting
131a2af
@FlorianDeconinck
Merge branch 'opt_geos_wrapper_bridge' into debug/pchakrab/aquaplanet…
dce3fb7 
…/root-358b60d
@FlorianDeconinck
Remove unused if leading to empty code block
8982542
@FlorianDeconinck
Restrict dace to 0.14.1 due to a parsing bug
da2f902
@FlorianDeconinck
Merge branch 'feature/dace_debug' into debug/pchakrab/aquaplanet/root…
f2799d8 
…-358b60d
@FlorianDeconinck
Add guard for bdt==0
27fae1c 
Fix bad merge for bdt with GEOS_Wrapper
@FlorianDeconinck
Verbose documentation of DaCe debug
9c8eb2f 
Clean up commented code
Verbose restriction of NaN to device memory
@FlorianDeconinck
Remove unused code
2f8ebac
@FlorianDeconinck
Merge branch 'feature/dace_debug' into opt_geos_wrapper_bridge
5d9e0a0
FlorianDeconinck and others added 13 commits March 27, 2023 15:53
@FlorianDeconinck
Merge remote-tracking branch 'nasa/feature/kernel_bw_tool' into opt_g…
b8edbf2 
…eos_wrapper_bridge
@FlorianDeconinck
Merge branch 'opt_geos_wrapper_bridge' into debug/pchakrab/aquaplanet…
f54b231 
…/root-358b60d
@FlorianDeconinck
Fix theroritical timings
81d00ce 
Lint
@pchakraborty
Fixed a bug where pkz was being calculated twice, and the second calc…
4891d56 
… was wrong
@FlorianDeconinck
Downgrade DaCe to 0.14.0 pending array aliasing fix
fafbfc7
@FlorianDeconinck
Set default cache path for orchestrated DaCe to respect GT_CACHE_* env
4fc5b4d
@FlorianDeconinck
Remove previous per stencil override of default_build_folder
2245027
@FlorianDeconinck
Revert "Set default cache path for orchestrated DaCe to respect GT_CA…
4f8fdc3 
…CHE_* env"

This reverts commit 4fc5b4d.
@FlorianDeconinck
Revert "Remove previous per stencil override of default_build_folder"
47421a0 
This reverts commit 2245027.
@FlorianDeconinck
Read cache_root in default dace backend
d51bc11
@FlorianDeconinck
Document faulty behavior with GT_CACHE_DIR_NAME
6bdd595
@FlorianDeconinck
Fix bad requirements syntax
80cbb01
@pchakraborty
Check for the string value of CONST_VERSION directly instead of enum
40f2440
@pchakraborty pchakraborty changed the title fix for diss_est and some GEOS specific changes Bug fixes, GEOS specific changes and documentation updates Apr 19, 2023
@pchakraborty pchakraborty marked this pull request as draft April 19, 2023 21:21
@pchakraborty pchakraborty marked this pull request as ready for review April 19, 2023 21:26
FlorianDeconinck
FlorianDeconinck requested changes Apr 20, 2023
View reviewed changes

@FlorianDeconinck FlorianDeconinck left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to have that NQ handled and the above comment edited to match

Comment thread fv3core/pace/fv3core/stencils/fv_dynamics.py Outdated
@FlorianDeconinck FlorianDeconinck merged commit 08f6e68 into geos/main Apr 20, 2023
@pchakraborty pchakraborty deleted the debug/pchakrab/aquaplanet/root-358b60d branch April 20, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FlorianDeconinck FlorianDeconinck FlorianDeconinck requested changes

Assignees

@FlorianDeconinck FlorianDeconinck

@pchakraborty pchakraborty

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pchakraborty @FlorianDeconinck